Follow the house shell conventions

Constants UPPER_SNAKE, mutable locals PascalCase, braced expansions
throughout, per Development/Coding conventions in the vault.
This commit is contained in:
fisher
2026-08-23 08:57:15 +00:00
parent 952de1ea8e
commit fc40facfc5
6 changed files with 131 additions and 108 deletions
+18 -18
View File
@@ -19,25 +19,25 @@ bold() { printf '\n\033[1m%s\033[0m\n' "$*"; }
bold "Host"
# Capture first: `eval ""` succeeds, so evaluating the failed call inline made
# the branch below unreachable and tripped `set -u` instead.
if host_config="$("${REPO_ROOT}/bin/cd-target" host-config 2>/dev/null)"; then
eval "$host_config"
printf ' %s, receiver on %s:%s\n' "$CD_HOST" "$CD_BIND" "$CD_PORT"
if HostConfig="$("${REPO_ROOT}/bin/cd-target" host-config 2>/dev/null)"; then
eval "${HostConfig}"
printf ' %s, receiver on %s:%s\n' "${CD_HOST}" "${CD_BIND}" "${CD_PORT}"
else
printf ' %s is not configured in targets.json\n' "$(hostname)"
printf ' answers to: %s\n' "$("${REPO_ROOT}/bin/cd-target" hostnames)"
fi
bold "Receiver"
state="$(systemctl --user is-active "$UNIT_NAME" 2>/dev/null || true)"
printf ' %-12s %s\n' "state" "${state:-not installed}"
if [[ "$state" == "active" ]]; then
State="$(systemctl --user is-active "${UNIT_NAME}" 2>/dev/null || true)"
printf ' %-12s %s\n' "state" "${State:-not installed}"
if [[ "${State}" == "active" ]]; then
printf ' %-12s %s\n' "since" \
"$(systemctl --user show "$UNIT_NAME" -p ActiveEnterTimestamp --value)"
"$(systemctl --user show "${UNIT_NAME}" -p ActiveEnterTimestamp --value)"
if command -v ss >/dev/null 2>&1 && [[ -n "${CD_PORT:-}" ]]; then
if ss -ltn 2>/dev/null | grep -q ":${CD_PORT}\b"; then
printf ' %-12s listening on port %s\n' "socket" "$CD_PORT"
printf ' %-12s listening on port %s\n' "socket" "${CD_PORT}"
else
printf ' %-12s \033[31mNOT listening on port %s\033[0m\n' "socket" "$CD_PORT"
printf ' %-12s \033[31mNOT listening on port %s\033[0m\n' "socket" "${CD_PORT}"
fi
fi
fi
@@ -49,25 +49,25 @@ if [[ -f "${CONFIG_DIR}/hooks.json" ]]; then
fi
bold "Targets on this host"
mapfile -t targets < <("${REPO_ROOT}/bin/cd-target" list 2>/dev/null || true)
if [[ ${#targets[@]} -eq 0 ]]; then
mapfile -t Targets < <("${REPO_ROOT}/bin/cd-target" list 2>/dev/null || true)
if [[ ${#Targets[@]} -eq 0 ]]; then
printf ' none\n'
else
for target in "${targets[@]}"; do
for Target in "${Targets[@]}"; do
# cd-deploy writes this on every terminal outcome. Reading a record
# beats grepping the log for phrases the log is free to reword.
status_file="${STATE_DIR}/${target}.status"
if [[ -f "$status_file" ]]; then
IFS=$'\t' read -r when result sha message < "$status_file" || true
StatusFile="${STATE_DIR}/${Target}.status"
if [[ -f "${StatusFile}" ]]; then
IFS=$'\t' read -r When Result Sha Message < "${StatusFile}" || true
printf ' %-22s %s %-4s %s %s\n' \
"$target" "$when" "$result" "$sha" "$message"
"${Target}" "${When}" "${Result}" "${Sha}" "${Message}"
else
printf ' %-22s %s\n' "$target" "never deployed from this host"
printf ' %-22s %s\n' "${Target}" "never deployed from this host"
fi
done
fi
bold "Recent receiver log"
journalctl --user -u "$UNIT_NAME" -n 15 --no-pager 2>/dev/null \
journalctl --user -u "${UNIT_NAME}" -n 15 --no-pager 2>/dev/null \
|| printf ' (no journal entries)\n'
echo